feat(build): allow skipping minikube during local builds #516
Conversation
openshift-ci-robot
added
the
size/XS
|
Is the aim of this to avoid calling |
|
It's to avoid calling minikube completely - I don't use it. |
|
What does your test flow look like then? Do you end up using the |
|
Yes, I use the olm-e2e image. Everything happens locally on my machine and nothing happens in a VM. I just set up my cluster beforehand and set the appropriate environment variables. (I use https://direnv.net to manage the collection of environment variables based on the directory I'm in too.) |
This only changes behavior if the NO_MINIKUBE variable is set, otherwise minikube calls will be done exactly as before.
|
Actually, I've been using the e2e-local target which ultimately ends up executing go test directly. But it looks like there's a docker target that can use the olm-e2e image. I'm asking that this get merged so that I can stop patching every local e2e I run. If others could benefit from a similar workflow, I don't mind working on adding some helper scripts to get a cluster easily running using the upstream hack script later on. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
feat(build): allow skipping minikube during local builds
njhale
added
the
kind/feature
This only changes behavior if the NO_MINIKUBE variable is set, otherwise minikube calls will be done exactly as before. (This probably only helps me out, but I'd really appreciate not having to comment out lines or apply a patch for each new branch I work on!)